Fix spelling suggestions analytics #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
force-pushed
the
fix-spelling-suggestions-analytics
branch
from
30f77c5 to
8665fbc
Compare
kr8n3r
force-pushed
the
fix-spelling-suggestions-analytics
branch
from
8665fbc to
303d152
Compare
kr8n3r
changed the title
kr8n3r
force-pushed
the
fix-spelling-suggestions-analytics
branch
from
303d152 to
7657911
Compare
Tetrino
approved these changes
Nov 4, 2019
barrucadu
reviewed
Nov 4, 2019
For finders where we show spelling suggestions, we want to track their page view impressions. First part of the work is in static alphagov/static#1927 Here we insert the meta tag into the document head for analytics script to pick up.
Update the way we track what spellign suggestions are being shown. As we're adding a meta tag for GA tracking, we now need to only update the meta tag content where there is and isn't a spelling suggestion.
kr8n3r
force-pushed
the
fix-spelling-suggestions-analytics
branch
from
7657911 to
05e469b
Compare
barrucadu
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on alphagov/static#1927
For finders where we show spelling suggestions, we want to track their page view impressions.
First part of the work is in static alphagov/static#1927
Here we insert the meta tag into the document head for analytics script to pick up.
As we're adding a meta tag for GA tracking, we now need to only update the meta tag content where there is and isn't a spelling suggestion.
Trello ticket
Search page examples to sanity check:
Other finders